Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTH48 (part 2) #200

Merged
merged 3 commits into from
Jul 10, 2024
Merged

AUTH48 (part 2) #200

merged 3 commits into from
Jul 10, 2024

Conversation

bifurcation
Copy link
Collaborator

The AUTH48 PR (#199) got merged a little early. This PR is to capture the last couple of minor things.

For @juberti:

  • Rephrased to avoid "process two frames together" altogether
  • Added missing "is"

For @murillo128: Re: Key ID vs. KID, Counter vs. CTR. I looked through the mentions here:

  • Most of the references to "Key ID" and "Counter" are in the "SFrame Header" section. I changed these to "KID" and "CTR".

  • I left the following expanded instances:

    • In the diagram in the "SFrame Ciphertext" section (before the definition in the "SFrame Header" section)
    • In "Overhead Analysis" / "Assumptions", since the other fields are in prose form

@bifurcation bifurcation requested a review from juberti as a code owner July 9, 2024 18:39
@bifurcation bifurcation requested a review from murillo128 July 9, 2024 18:39
juberti
juberti approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@juberti juberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, also fixed one other missing word with this commit: 7c61b5a

murillo128
murillo128 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@murillo128 murillo128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you for addressing my feedback!

@bifurcation
Copy link
Collaborator Author

Thanks for the quick re-reviews! I'll send this off to the RFC Editor.

@bifurcation bifurcation merged commit de8462b into main Jul 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juberti juberti juberti approved these changes

@murillo128 murillo128 murillo128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bifurcation @murillo128 @juberti